Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPEGView.ini.tpl file not up-to-date with JPEGView.ini #60

Open
LaurentGrenet opened this issue May 2, 2022 · 5 comments
Open

JPEGView.ini.tpl file not up-to-date with JPEGView.ini #60

LaurentGrenet opened this issue May 2, 2022 · 5 comments
Labels
bug Something isn't working config opts Related to configuration options, config files, or keymap files documentation Improvements or additions to documentation

Comments

@LaurentGrenet
Copy link

The file JPEGView.ini.tpl seems to be not exactly up-to-date : in particular, it still defines the "ColorCorrection" option with quotes (while since #12 it seems it shouln't...)

Moreover, around definition of Users command, it seems to be a little outdated versus JPEGView.ini (even if i'm not sure in this second case...)

@sylikc
Copy link
Owner

sylikc commented May 5, 2022

So, the JPEGView.ini and the .tpl files... I've been a bit busy recently but I'm trying to redesign the layout for that... the way the JPEGView.ini and the template and the user config interact is really clunky right now and it's something I want to change...

@sylikc sylikc changed the title JPEGView.ini.tpl file seems to be not up-to-date JPEGView.ini.tpl file not up-to-date with JPEGView.ini May 5, 2022
@sylikc
Copy link
Owner

sylikc commented May 5, 2022

Oh, so I didn't address the actual issue. So right now, the .tpl file is what JPEGView uses to create the "user" ini. Plus, there's the internationalized versions.

But it's not the active use INI... the JPEGView.ini itself has an option which states which INI it's going to use. There's also a command line option and it cascades from

user -> "inside JPEGView directory" -> code defaults

But the tpl files just don't get updated as much, and I feel like it's really duplicative... so, I was going to get rid of it entirely. But the way it's structured right now, really can't without making some JPEGView.ini un-editable. ... still designing...

@sylikc sylikc added bug Something isn't working documentation Improvements or additions to documentation labels May 5, 2022
@LaurentGrenet
Copy link
Author

The issue is the fact that the tpl file is used to create the initial user ini file.
As a result, even if the tpl is not "active", the user ini file (that is "active") is then wrong for the ColorCorrection parameter.
Obviously, it can be easily corrected afterwards... but it would be better it is corretly initialized....

@sylikc
Copy link
Owner

sylikc commented May 5, 2022

Right. So I created a branch but was ready to overhaul the whole bit... because I think the whole thing is really clunky. Oh, in addition, the keymap.txt needs to work the exact same way (that's why it's taking some time to figure out), aka like issue #40

@sylikc
Copy link
Owner

sylikc commented Aug 29, 2022

I think I'm almost ready to try to tackle this problem... still deciding how to necessarily cascade the settings with the least confusion... I don't think the original author really thought about the non-portable use case

@sylikc sylikc added the config opts Related to configuration options, config files, or keymap files label Jan 19, 2023
@sylikc sylikc added this to the Pending Features milestone Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working config opts Related to configuration options, config files, or keymap files documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants