Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDS format support #326

Open
Anutim opened this issue Jul 30, 2024 · 6 comments · May be fixed by #352
Open

DDS format support #326

Anutim opened this issue Jul 30, 2024 · 6 comments · May be fixed by #352

Comments

@Anutim
Copy link

Anutim commented Jul 30, 2024

Hey, just wanted request DDS support incase anyone might be interested in adding support for it. It's the last format I commonly use that I can't use jpegview for.

@Raghav-B Raghav-B linked a pull request Dec 28, 2024 that will close this issue
@Raghav-B
Copy link

Raghav-B commented Jan 4, 2025

Hi @Anutim, not sure if this is still something you need, but I've opened a PR which adds DDS support for most sub-formats. Do let me know if this helps you out!

@Anutim
Copy link
Author

Anutim commented Jan 4, 2025

Hi @Anutim, not sure if this is still something you need, but I've opened a PR which adds DDS support for most sub-formats. Do let me know if this helps you out!

I don't have Visual Studio installed so can't test it as is, but that is fantastic!

And it's still definitely something I'd want. While Windows Explorer supports previews for DDS in general, it's still pretty awkward incase I have to zoom in on some detail. Explorer also doesn't support previewing 888/8888 etc, so would definitely be great with that too even if use of them is quite rare.

@Raghav-B
Copy link

It would be great if you could test it out since the DDS build has been very useful for my work. Hmm, I could create a custom release on my fork with a binary you could download? Not sure if that's something you would be comfortable with however.

@sylikc
Copy link
Owner

sylikc commented Jan 15, 2025

I'll take a look at it and merge it. I'm due for a release. I originally wanted to sign it but maybe I'll just leave it unsigned for one more release and just put the PRs in

Thanks for the contribution. I'm sorry I've been kinda MIA for a few months

@Raghav-B
Copy link

No worries @sylikc, just happy to contribute to something I use daily! I've marked #352 as draft for now since I want to be thorough and ensure it works with all the DDS formats listed in the PR description. Will probably have it done over the weekend.

@Anutim
Copy link
Author

Anutim commented Jan 17, 2025

It would be great if you could test it out since the DDS build has been very useful for my work. Hmm, I could create a custom release on my fork with a binary you could download? Not sure if that's something you would be comfortable with however.

Yeah, sure, I'd appreciate it!

EDIT: Oh, I might as well wait actually if y'all are merging it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants