Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion - Add Dark theme & Mica backdrop to the Title Bar #180

Open
MG240 opened this issue Mar 26, 2023 · 5 comments
Open

Suggestion - Add Dark theme & Mica backdrop to the Title Bar #180

MG240 opened this issue Mar 26, 2023 · 5 comments
Labels
duplicate This issue or pull request already exists

Comments

@MG240
Copy link

MG240 commented Mar 26, 2023

No description provided.

@sylikc sylikc added the duplicate This issue or pull request already exists label Mar 31, 2023
@sylikc
Copy link
Owner

sylikc commented Mar 31, 2023

This is a duplicate of #71 and it's currently known issue.

I've looked into those API calls and stuff, but it's no easy feat.

Even the windows implementation says, it's not like windows automatically helps you draw things inverted, but rather, the application needs to be built with dark theme in mind.

My first approach would be to make the menu dark and possibly the title bar, but this is pending and not priority at the moment.

@MG240
Copy link
Author

MG240 commented Mar 31, 2023

Temporarily, I tried using MicaForEveryone by adding "Process Rule :JPEGView" to add Dark Titlebar & Mica Backdrop and it works. But JPEGView loses the theme after reopening.

20230331_113647002

@oTnTh
Copy link

oTnTh commented May 24, 2023

Please take a look at this: https://github.com/ysc3839/win32-darkmode

I've tried and made a patch for jpegview: dark.patch.zip

Title bar and right-click menu worked in MainDlg, but FileOpenDialog didn't.

001 002

If anyone wanna try: JPEGView.x64.zip

@sylikc
Copy link
Owner

sylikc commented Jun 15, 2023

Thanks for the initial work @oTnTh let me look into the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants