magithub warning: Error (use-package): magithub/:config: feature pull-request-merge failed to install: nil

[robbyoconnor]

Description

magithub config is slightly broken, but not in an unusable way

Reproduction guide 🪲

• Start Emacs
• Have the github layer enabled
• See warning

Observed behaviour: 👀 💔

Error (use-package): magithub/:config: feature pull-request-merge failed to install: nil

Expected behaviour: ❤️ 😄
No warning

System Info 💻

• OS: gnu/linux
• Emacs: 27.0.50
• Spacemacs: 0.300.0
• Spacemacs branch: develop (rev. 95422ae)
• Graphic display: t
• Distribution: spacemacs
• Editing style: vim
• Completion: ivy
• Layers:

(windows-scripts prettier sphinx web-beautify transmission xclipboard node selectric
                 (templates :variables templates-private-directory "~/.spacemacs.d/templates")
                 coffeescript json jsonnet julia epub bibtex nginx twitter graphviz
                 (ivy :variables ivy-enable-advanced-buffer-information t)
                 asciidoc elfeed speed-reading swift plantuml
                 (auto-completion :variables auto-completion-return-key-behavior 'complete auto-completion-tab-key-behavior 'cycle auto-completion-complete-with-key-sequence nil auto-completion-enable-help-tooltip t auto-completion-enable-sort-by-usage t auto-completion-show-snippets-in-popup t auto-completion-private-snippets-directory "~/.spacemacs.d/snippets")
                 better-defaults emacs-lisp
                 (git :variables git-magit-status-fullscreen t)
                 github gnus version-control
                 (markdown :variables markdown-live-preview-engine 'vmd)
                 syntax-checking
                 (latex :variables latex-enable-auto-fill t)
                 (colors :variables colors-colorize-identifiers 'all colors-enable-nyan-cat-progress-bar t)
                 docker
                 (ansible :variables ansible-auto-encrypt-decrypt t)
                 puppet evil-commentary
                 (evil-snipe :variables evil-snipe-enable-alternate-f-and-t-behaviors t)
                 fasd finance floobits xkcd autohotkey csv major-modes
                 (go :variables go-backend 'lsp gofmt-command "goimports" go-format-before-save t go-use-gometalinter t go-use-gocheck-for-testing t go-use-test-args "-race -timeout 10s" godoc-at-point-function 'godoc-gogetdoc go-tab-width 2)
                 (haskell :variables haskell-enable-ghci-ng-support t haskell-enable-shm-support t haskell-enable-hindent-style "andrew-gibiansky")
                 html java
                 (javascript :variables javascript-disable-tern-port-files t javascript-backend 'lsp)
                 (python :variables python-backend 'lsp python-enable-yapf-format-on-save t python-fill-column 80 python-auto-set-local-pyenv-version 'on-visit python-auto-set-local-pyvenv-virtualenv 'on-visit python-sort-imports-on-save t python-test-runner
                         '(nose pytest))
                 lsp racket
                 (ruby :variables ruby-version-manager `rvm)
                 ruby-on-rails
                 (rust :variables rust-enable-rustfmt-on-save t)
                 (scala :variables scala-indent:use-javadoc-style t scala-enable-eldoc t scala-auto-insert-asterisk-in-comments t scala-use-unicode-arrows t scala-auto-start-ensime t)
                 shell-scripts
                 (restclient :variables restclient-use-org t)
                 themes-megapack tmux vim-empty-lines spotify pandoc vagrant
                 (ibuffer :variables ibuffer-group-buffers-by 'projects)
                 semantic deft
                 (shell :variables shell-default-shell 'ansi-term shell-default-position 'bottom shell-default-height 30 shell-default-term-shell "/bin/zsh")
                 typescript erc chrome d emoji gtags prodigy evernote
                 (org :variables org-enable-github-support t org-enable-reveal-js-support t org-enable-org-journal-support t org-enable-hugo-support t org-projectile-file "TODOs.org" org-want-todo-bindings t org-enable-bootstrap-support t)
                 search-engine yaml sql nim lua scheme purescript sml common-lisp ranger wakatime dash spell-checking jabber cscope vinegar games react php vimscript geolocation idris
                 (elm :variables elm-reactor-port "3000" elm-reactor-address "0.0.0.0")
                 elixir
                 (typography :variables typography-enable-typographic-editing nil)
                 emberjs pdf imenu-list slack systemd command-log
                 (terraform :variables terraform-auto-format-on-save t)
                 pass parinfer groovy kotlin unicode-fonts epub multiple-cursors
                 (treemacs :variables treemacs-use-follow-mode t treemacs-use-filewatch-mode t treemacs-use-collapsed-directories 3))

• System configuration features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LIBSYSTEMD PDUMPER LCMS2 GMP

[bmag]

Most certainly an upstream issue at https://github.com/vermiculus/magithub/ due to magit/magit#3728, and probably not the only one, so please report upstream.

Specifically this issue stems from magithub-core.el:

  `((pull-request-merge . ,(lambda ()
                             (require 'magit-popup nil t)
                             (when (boundp 'magit-am-popup)
                               (magit-define-popup-action 'magit-am-popup
                                 ?P "Apply patches from pull request"
                                 #'magithub-pull-request-merge)
                               t)))

magit-am-popup was renamed to magit-am and magit-am-popup is not bounded, hence the lambda return nil, causing (in another part of the flow) the error message you encountered. There are more problems with that function, actually: magit-popup is no longer a dependency of magit and might not be installed. Specifically magit-define-popup-action is maybe undefined and in any case won't work on magit-am.

@syl20bnr we might need to disable magithub until it's fixed

[syl20bnr]

I'm for removing magithub and use only forge in spacemacs.

[syl20bnr]

I commented magithub in last develop, please move it to your private layer.
Keeping this open as the core issue has not been fixed.

[robbyoconnor]

@syl20bnr -- I dont actually care -- if forge does everything -- no need for it!

Will report upstream when I have cycles to so.

[Miciah]

Upstream report: vermiculus/magithub#402

[robbyoconnor]

Thank you!

…

On 2/19/19 12:53 PM, Miciah Dashiel Butler Masters wrote: Upstream report: vermiculus/magithub#402 <vermiculus/magithub#402> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11990 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABaMJZQrHsEZEz5gJja0RHTtpfeXGhrks5vPDosgaJpZM4a_OdT>.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

[robbyoconnor]

Fixed upstream.