Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary visibility from constructors #180

Merged
merged 1 commit into from
May 2, 2023
Merged

fix: remove unnecessary visibility from constructors #180

merged 1 commit into from
May 2, 2023

Conversation

nmlinaric
Copy link
Contributor

Description

Removes unnecessary public visibility from constructors, visibility for constructors has been deprecated.

Related Issue Or Context

Closes: #170

How Has This Been Tested? Testing details.

manual review

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@nmlinaric nmlinaric requested a review from stevenjla April 21, 2023 08:05
stevenjla
stevenjla approved these changes Apr 29, 2023
View reviewed changes
Copy link

@stevenjla stevenjla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nmlinaric nmlinaric merged commit a771697 into master May 2, 2023
@nmlinaric nmlinaric deleted the nmlinaric/constructor-visibility branch May 2, 2023 13:26
@mpetrun5 mpetrun5 mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjla stevenjla stevenjla approved these changes

@MakMuftic MakMuftic MakMuftic approved these changes

@mpetrun5 mpetrun5 mpetrun5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Unnecessary Visibility From Constructors
4 participants
@nmlinaric @mpetrun5 @MakMuftic @stevenjla