Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add native token handler and adapter #254

Merged
merged 7 commits into from
Jul 15, 2024

Conversation

nmlinaric
Copy link
Contributor

Description

Adds adapter and native token handler (modifier erc20 handler) for native token transfers (intended to be used for BTC<>EVM)

Related Issue Or Context

Closes: #231

How Has This Been Tested? Testing details.

unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@nmlinaric nmlinaric force-pushed the nmlinaric/native-adapter branch from 8fd8ea5 to 8734a7e Compare July 3, 2024 13:32
contracts/adapters/nativeTokens/NativeTokenAdapter.sol Outdated Show resolved Hide resolved
contracts/handlers/NativeTokenHandler.sol Outdated Show resolved Hide resolved
contracts/handlers/NativeTokenHandler.sol Outdated Show resolved Hide resolved
test/adapters/native/deposit.js Outdated Show resolved Hide resolved
@nmlinaric nmlinaric requested a review from lastperson July 8, 2024 19:34
contracts/handlers/NativeTokenHandler.sol Outdated Show resolved Hide resolved
contracts/handlers/NativeTokenHandler.sol Outdated Show resolved Hide resolved
contracts/handlers/NativeTokenHandler.sol Outdated Show resolved Hide resolved
contracts/handlers/NativeTokenHandler.sol Outdated Show resolved Hide resolved
contracts/handlers/NativeTokenHandler.sol Outdated Show resolved Hide resolved
contracts/handlers/NativeTokenHandler.sol Outdated Show resolved Hide resolved
contracts/handlers/NativeTokenHandler.sol Outdated Show resolved Hide resolved
contracts/handlers/NativeTokenHandler.sol Show resolved Hide resolved
contracts/handlers/NativeTokenHandler.sol Outdated Show resolved Hide resolved
contracts/handlers/NativeTokenHandler.sol Outdated Show resolved Hide resolved
@nmlinaric nmlinaric requested a review from lastperson July 10, 2024 08:46
Copy link
Contributor

@lastperson lastperson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the code, perhaps Adapter could use the docs,

@nmlinaric nmlinaric requested a review from mpetrun5 July 15, 2024 15:50
@nmlinaric nmlinaric merged commit d5cea35 into master Jul 15, 2024
5 checks passed
@nmlinaric nmlinaric deleted the nmlinaric/native-adapter branch July 15, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapter for native currency transfers
3 participants