Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: extend IFeeHandler with feeHandlerType getter #248

Merged
merged 1 commit into from
Jun 7, 2024
Merged

chore: extend IFeeHandler with feeHandlerType getter #248

merged 1 commit into from
Jun 7, 2024

Conversation

nmlinaric
Copy link
Contributor

Description

Adds feeHandlerType getter to IFeeHandler

How Has This Been Tested? Testing details.

unti tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@nmlinaric nmlinaric changed the title extend IFeeHandler with feeHandlerType getter chore: extend IFeeHandler with feeHandlerType getter Jun 5, 2024
@nmlinaric nmlinaric force-pushed the nmlinaric/fee-handler-type-getter branch from f1fe07d to f2f51a2 Compare June 6, 2024 13:06
@nmlinaric nmlinaric merged commit e4bb75f into master Jun 7, 2024
5 checks passed
@nmlinaric nmlinaric deleted the nmlinaric/fee-handler-type-getter branch June 7, 2024 13:11
@mpetrun5 mpetrun5 mentioned this pull request Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saadahmsiddiqui saadahmsiddiqui saadahmsiddiqui approved these changes

@MakMuftic MakMuftic MakMuftic approved these changes

@tcar121293 tcar121293 Awaiting requested review from tcar121293

@mpetrun5 mpetrun5 Awaiting requested review from mpetrun5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmlinaric @MakMuftic @saadahmsiddiqui