Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend fee calculation formula #244

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

nmlinaric
Copy link
Contributor

Description

Extends the fee calculation formula with the option to charge on top of execution fee a protocol fee.
Protocol fee can be a fixed amount of native token or a percentage of the execution cost.

Related Issue Or Context

Closes: #242

How Has This Been Tested? Testing details.

unit test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@nmlinaric nmlinaric force-pushed the nmlinaric/protocol-fee branch from fcdae1f to 93b6fb9 Compare May 27, 2024 07:25
@nmlinaric nmlinaric force-pushed the nmlinaric/protocol-fee branch from 20f796f to 73267ea Compare May 27, 2024 10:37
@nmlinaric nmlinaric requested a review from lastperson June 3, 2024 13:01
@nmlinaric nmlinaric merged commit cfc09d8 into master Jun 3, 2024
5 checks passed
@nmlinaric nmlinaric deleted the nmlinaric/protocol-fee branch June 3, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Twap fee handlers (aka Dynamic fh v2)
3 participants