Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add zero check for price #237

Merged
merged 2 commits into from
May 21, 2024
Merged

fix: add zero check for price #237

merged 2 commits into from
May 21, 2024

Conversation

andersonlee111
Copy link
Contributor

@andersonlee111 andersonlee111 commented May 8, 2024 •
edited
Loading

Description

Added a revert when the destination coin's price was set to 0.

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@andersonlee111 andersonlee111 requested a review from lastperson May 8, 2024 15:40
@nmlinaric nmlinaric merged commit f1fc767 into master May 21, 2024
5 checks passed
@nmlinaric nmlinaric deleted the anderson/add-zeroCheck-price branch May 21, 2024 09:20
@mpetrun5 mpetrun5 mentioned this pull request May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lastperson lastperson lastperson approved these changes

@mpetrunic mpetrunic mpetrunic approved these changes

@MakMuftic MakMuftic MakMuftic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andersonlee111 @lastperson @mpetrunic @MakMuftic @nmlinaric