Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor decoding in permissionless handler #210

Merged
merged 1 commit into from
May 28, 2024
Merged

chore: refactor decoding in permissionless handler #210

merged 1 commit into from
May 28, 2024

Conversation

viatrix
Copy link
Contributor

@viatrix viatrix commented Nov 28, 2023

Refactored decoding in PermissionlessGenericHandler to improve readability of the code

Description

Refactored decoding in PermissionlessGenericHandler to improve readability of the code

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

All the tests remained the same. All the tests pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

lastperson
lastperson approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@lastperson lastperson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!
Maybe there is a way to make the encoding comments section more compact as well?

@nmlinaric nmlinaric mentioned this pull request May 20, 2024
Closed
@nmlinaric nmlinaric merged commit ee0954f into master May 28, 2024
5 checks passed
@nmlinaric nmlinaric deleted the viatrix/update-permissionless-encoding branch May 28, 2024 08:59
@mpetrun5 mpetrun5 mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrun5 mpetrun5 mpetrun5 approved these changes

@lastperson lastperson lastperson approved these changes

@nmlinaric nmlinaric Awaiting requested review from nmlinaric

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viatrix @lastperson @mpetrun5 @nmlinaric