Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit gas for permissionless generic calls #199

Closed
mpetrun5 opened this issue Sep 19, 2023 · 0 comments · Fixed by #200
Closed

Limit gas for permissionless generic calls #199

mpetrun5 opened this issue Sep 19, 2023 · 0 comments · Fixed by #200
Assignees
@mpetrun5
Milestone
Cycle 2

Comments

@mpetrun5
Copy link
Collaborator

Use max fee field as gas for the external permissionless generic call.

Implementation details

Decode max fee from the execution data and set it to call (call{gas: maxFee}.functionCall())

Testing details

  • unit tests that the call is not reverted even though gas limit is exceeded

Acceptance Criteria
@mpetrun5 mpetrun5 mentioned this issue Sep 19, 2023
Merged
9 tasks
@mpetrun5 mpetrun5 self-assigned this Sep 19, 2023
@MakMuftic MakMuftic added this to the Cycle 2 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpetrun5 mpetrun5

Labels
None yet
Projects
None yet
Milestone
Cycle 2
Development

Successfully merging a pull request may close this issue.

feat: limit permissionless generic call gas usage sygmaprotocol/sygma-solidity
2 participants
@mpetrun5 @MakMuftic