Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check successful transfer when minting XC20 tokens #186

Merged
merged 2 commits into from
May 2, 2023
Merged

fix: check successful transfer when minting XC20 tokens #186

merged 2 commits into from
May 2, 2023

Conversation

nmlinaric
Copy link
Contributor

@nmlinaric nmlinaric commented Apr 21, 2023 •
edited
Loading

Description

Use _safeTransfer() insead of transfer() to prevent failed transfers, but mintERC20 successful.

Related Issue Or Context

Closes: #168

How Has This Been Tested? Testing details.

unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

lastperson
lastperson requested changes Apr 24, 2023
View reviewed changes
contracts/XC20Safe.sol Outdated Show resolved Hide resolved
@nmlinaric nmlinaric requested a review from lastperson April 24, 2023 12:04
@nmlinaric nmlinaric force-pushed the nmlinaric/xc20-transfer branch from 993284f to f23d7f3 Compare April 24, 2023 12:07
@nmlinaric nmlinaric merged commit 84732d0 into master May 2, 2023
@nmlinaric nmlinaric deleted the nmlinaric/xc20-transfer branch May 2, 2023 13:29
@mpetrun5 mpetrun5 mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjla stevenjla stevenjla approved these changes

@MakMuftic MakMuftic MakMuftic approved these changes

@mpetrun5 mpetrun5 mpetrun5 approved these changes

@lastperson lastperson lastperson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return Value From ERC20 Transfer Ignored
5 participants
@nmlinaric @lastperson @mpetrun5 @MakMuftic @stevenjla