Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Value From ERC20 Transfer Ignored #168

Closed
nmlinaric opened this issue Apr 13, 2023 · 0 comments · Fixed by #186
Closed

Return Value From ERC20 Transfer Ignored #168

nmlinaric opened this issue Apr 13, 2023 · 0 comments · Fixed by #186
Assignees

Comments

@nmlinaric
Copy link
Contributor

mintERC20 function ignores the return value from the transfer function of the ERC20 token. The transaction can succeed even if a token transfer fails. This could have downstream effects on the accounting of tokens by the bridge.

Implementation details

mintERC20 function should check return value of transfer.

Testing details

Minting tests with success and fail cases.

Acceptance Criteria

Unit and e2e passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants