You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mintERC20 function ignores the return value from the transfer function of the ERC20 token. The transaction can succeed even if a token transfer fails. This could have downstream effects on the accounting of tokens by the bridge.
Implementation details
mintERC20 function should check return value of transfer.
Testing details
Minting tests with success and fail cases.
Acceptance Criteria
Unit and e2e passing
The text was updated successfully, but these errors were encountered:
mintERC20
function ignores the return value from the transfer function of the ERC20 token. The transaction can succeed even if a token transfer fails. This could have downstream effects on the accounting of tokens by the bridge.Implementation details
mintERC20
function should check return value of transfer.Testing details
Minting tests with success and fail cases.
Acceptance Criteria
Unit and e2e passing
The text was updated successfully, but these errors were encountered: