Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement handler response on proposal execution #167

Merged
merged 7 commits into from
May 10, 2023

Conversation

nmlinaric
Copy link
Contributor

@nmlinaric nmlinaric commented Apr 13, 2023

Description

Implements handlerReponse in executeProposal function which is passed to ProposalExecution event.

Related Issue Or Context

Closes: #166

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@nmlinaric nmlinaric force-pushed the nmlinaric/handler-reponse branch from 1da324a to d167d3b Compare May 2, 2023 11:32
@nmlinaric nmlinaric marked this pull request as ready for review May 2, 2023 11:43
Copy link
Contributor

@lastperson lastperson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think we need to use abi.encode to make the data easily decodeable.
  2. Wouldn't it make sense to return all the useful information from the handler if we are at it already?

@nmlinaric nmlinaric requested a review from lastperson May 9, 2023 09:50
@nmlinaric nmlinaric merged commit ae04b0c into master May 10, 2023
@nmlinaric nmlinaric deleted the nmlinaric/handler-reponse branch May 10, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return handler response on executeProposal and emit in event
4 participants