Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unneccessary dependencies #163

Merged
merged 4 commits into from
Feb 22, 2023
Merged

fix: remove unneccessary dependencies #163

merged 4 commits into from
Feb 22, 2023

Conversation

mpetrunic
Copy link
Member

Can we remove private key signing altogether or move it to different package?

Description

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@MakMuftic
Copy link
Contributor

Remove it altogether, as fee oracle is the one signing this information - never SDK. I guess this flow is here from the time that our local setup with fee oracle was still being worked on - @wainola @enemycnt please confirm this.

packages/sdk/package.json Outdated Show resolved Hide resolved
@enemycnt enemycnt self-requested a review February 21, 2023 13:15
enemycnt
enemycnt previously approved these changes Feb 21, 2023
@enemycnt enemycnt merged commit dec73cd into main Feb 22, 2023
@enemycnt enemycnt deleted the fix/remove-extra-deps branch February 22, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants