Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix amount in createOracleFeeData #162

Merged
merged 2 commits into from
Feb 14, 2023
Merged

fix: fix amount in createOracleFeeData #162

merged 2 commits into from
Feb 14, 2023

Conversation

enemycnt
Copy link
Contributor

@enemycnt enemycnt commented Feb 10, 2023 •
edited
Loading

Description

Related Issue Or Context

Closes: #164

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@enemycnt enemycnt requested a review from wainola February 10, 2023 16:46
@enemycnt enemycnt changed the title fix amount in createOracleFeeData fix: fix amount in createOracleFeeData Feb 10, 2023
wainola
wainola previously approved these changes Feb 10, 2023
View reviewed changes
@enemycnt enemycnt requested a review from mpetrun5 February 13, 2023 17:58
@enemycnt enemycnt merged commit a39180d into main Feb 14, 2023
@enemycnt enemycnt deleted the fix/oracle-amount branch February 14, 2023 10:48
@github-actions github-actions bot mentioned this pull request Feb 14, 2023
Merged
@enemycnt enemycnt mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakMuftic MakMuftic MakMuftic approved these changes

@mpetrun5 mpetrun5 mpetrun5 approved these changes

@wainola wainola wainola left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix fee oracle behavior
4 participants
@enemycnt @wainola @mpetrun5 @MakMuftic