Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix url to query oracle service #159

Merged
merged 1 commit into from
Feb 10, 2023
Merged

fix: Fix url to query oracle service #159

merged 1 commit into from
Feb 10, 2023

Conversation

wainola
Copy link
Contributor

@wainola wainola commented Feb 9, 2023 •
edited
Loading

Description

Fix url to query fee oracle service, passing msgGasLimit as query param

Related Issue Or Context

Closes: #160

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@wainola wainola requested a review from enemycnt February 9, 2023 21:01
@wainola wainola changed the title Fix url to query oracle service fix: Fix url to query oracle service Feb 9, 2023
@wainola wainola mentioned this pull request Feb 9, 2023
Merged
9 tasks
@enemycnt enemycnt merged commit ea762a0 into main Feb 10, 2023
@enemycnt enemycnt deleted the fix/fix-feeOracle-url branch February 10, 2023 11:50
@github-actions github-actions bot mentioned this pull request Feb 10, 2023
Merged
@enemycnt enemycnt mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakMuftic MakMuftic MakMuftic approved these changes

@enemycnt enemycnt enemycnt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix url to query fee oracle service
3 participants
@wainola @enemycnt @MakMuftic