feat: substrate support to SDK #154
Conversation
enemycnt
changed the title
examples/substrate-react-example/src/substrate-lib/SubstrateContext.tsx
Outdated
Show resolved
Hide resolved
examples/substrate-react-example/src/substrate-lib/SubstrateContext.tsx
Outdated
Show resolved
Hide resolved
enemycnt
changed the title
| return Loader( | ||
| "Loading accounts (please review any extension's authorization)" | ||
| ); | ||
| } |
There was a problem hiding this comment.
The code block with error handling could be improved by using constants for the status. It could also be separated into another method for error handling.
What is the possible error state when using "!== READY"? Can we compare the exact values as it gives the feeling of some potential unknown keyring value?
| from: string; | ||
| to: string; | ||
| }): Promise<void> => { | ||
| console.log('form data', values); |
| console.log('form data', values); | ||
| if (values.amount && values.address) { | ||
| setIsLoading(true) | ||
| makeDeposit(values.amount, values.address, values.to).finally(() => { |
|
|
||
| return ( | ||
| <form | ||
| action="" |
There was a problem hiding this comment.
Empty action could be removed
| return ( | ||
| <form | ||
| action="" | ||
| onSubmit={(...args) => void handleSubmit(submit)(...args)} |
There was a problem hiding this comment.
Do we need a destructuring assignment for the object?
| key: account.address, | ||
| value: account.address, |
| text: (account.meta.name as String).toUpperCase(), | ||
| icon: "user", | ||
| })); | ||
| const initialAddress = |
There was a problem hiding this comment.
move to the method getInitialAddress
| : ""; | ||
| // Set the initial address | ||
| useEffect(() => { | ||
| !currentAccount && |
There was a problem hiding this comment.
refactor to readable expressions, like:
function accountExists() return !currentAccount && initialAddress.length > 0
if(accountExists()) {
setCurrentAccount(keyring?.getPair(initialAddress))
}
| ) : ( | ||
| "No accounts found" | ||
| )} |
There was a problem hiding this comment.
use the early return of component if an account is not set:
if (!currentAccount) {
return "No accounts found"
}
return (
<div
style={{
display: "flex",
flexDirection: "column",
alignItems: "center",
}}
>
Account data
| export default function Metadata(props: any) { | ||
| const state = useSubstrateState(); | ||
| const api = state?.api; | ||
| return api?.rpc && api.rpc.state ? <Main {...props} /> : null; |
There was a problem hiding this comment.
if we are relying on the state we can use:
api?.rpc?.state
Or you can use lodash
get(api, 'rpc.state', null)
|
|
||
| export type SubstrateContextType = { | ||
| state: StateType; | ||
| setCurrentAccount: (acct: unknown) => void; |
There was a problem hiding this comment.
should the parameter be account?
|
|
||
| useEffect(() => { | ||
| const { apiState, keyringState, api } = state; | ||
| if (apiState === "READY" && api && !keyringState && !keyringLoadAll) { |
There was a problem hiding this comment.
constants for status like "READY"
| useEffect(() => { | ||
| const { apiState, keyringState, api } = state; | ||
| if (apiState === "READY" && api && !keyringState && !keyringLoadAll) { | ||
| console.log("load"); |
| ); | ||
| }; | ||
|
|
||
| const useSubstrate = () => useContext(SubstrateContext); |
There was a problem hiding this comment.
make a guard if the context is not used with provider:
function useSubstrate() {
const context = useContext(SubstrateContext)
if (context === undefined) {
throw new Error('useSubstrate must be used within a SubstrateContext')
}
return context
}
| systemChain: string; | ||
| systemChainType: ChainType; | ||
| }> => { | ||
| const [systemChain, systemChainType] = await Promise.all([ |
There was a problem hiding this comment.
Simplify the code:
const chainPromise = api?.rpc?.system?.chainType ? api.rpc.system.chainType() : Promise.resolve(LiveChainType)
const [systemChain, systemChainType] = await Promise.all([
api.rpc.system.chain()
chainPromise()
])
Description
Related Issue Or Context
Closes: #93
Closes: #92
Closes: #144
Closes: #89
How Has This Been Tested? Testing details.
Types of changes
Checklist: