Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update utility functions to accomodate permissionless and permissioned handlers #132

Merged
merged 4 commits into from
Jan 13, 2023

Conversation

wainola
Copy link
Contributor

@wainola wainola commented Dec 15, 2022

Implements and rename utility functions to prepare data for permissionless and permissioned generic handler

Description

  • rename and modify createGenericDepositDataV1 into createPermissionlessGenericDepositData
  • create createPermissionedGenericDepositData

Related Issue Or Context

Closes: #128

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@wainola wainola requested a review from enemycnt December 15, 2022 12:55
@wainola wainola changed the title update utility functions to accomodate permissionless and permissioned handlers feat: update utility functions to accomodate permissionless and permissioned handlers Jan 9, 2023
@wainola wainola merged commit e49feac into main Jan 13, 2023
@wainola wainola deleted the feat/update-generic-msg branch January 13, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Generic message format according to new permissionless handler
2 participants