Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: query param base impl #153

Merged
merged 6 commits into from
Feb 20, 2024
Merged

feat: query param base impl #153

merged 6 commits into from
Feb 20, 2024

Conversation

wainola
Copy link
Contributor

@wainola wainola commented Feb 13, 2024

Description

Related Issue Or Context

Closes: #104

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in sygma-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

Copy link

cloudflare-workers-and-pages bot commented Feb 13, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a5d2f8a
Status: ✅  Deploy successful!
Preview URL: https://cd52d0fc.explorer-ui-qxq.pages.dev
Branch Preview URL: https://feat-use-query-param.explorer-ui-qxq.pages.dev

View logs

@wainola wainola requested a review from MakMuftic February 16, 2024 13:04
@wainola wainola marked this pull request as ready for review February 16, 2024 13:04
@LyonSsS
Copy link
Contributor

LyonSsS commented Feb 19, 2024

Tested by QA on #104 - this is ready to be merged

Copy link
Contributor

@LyonSsS LyonSsS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by QA here #104 . This PR is ready to be mergerd

@MakMuftic MakMuftic merged commit aa60682 into main Feb 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use query param in url to track state
3 participants