Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use query param in url to track state #104

Closed
mpetrun5 opened this issue Oct 18, 2023 · 6 comments · Fixed by #153
Closed

Use query param in url to track state #104

mpetrun5 opened this issue Oct 18, 2023 · 6 comments · Fixed by #153

Comments

@mpetrun5
Copy link
Contributor

mpetrun5 commented Oct 18, 2023

Right now, if send someone the link it always goes back to the first page. We should have page query param in URL and that be the state tracker so you always can land on the exact page you were looking at before.

Implementation details

Add ?page= to list view urls and fetch transfers based on that.

Testing details

Acceptance Criteria

@MakMuftic MakMuftic added this to the Cycle 3 milestone Oct 20, 2023
@MakMuftic MakMuftic removed this from the Cycle 3+4 milestone Jan 4, 2024
@MakMuftic MakMuftic added the QA label Jan 12, 2024
@wainola
Copy link
Contributor

wainola commented Feb 16, 2024

@LyonSsS here is the URL of the deployed branch for QA: https://feat-use-query-param.explorer-ui-qxq.pages.dev/

@LyonSsS
Copy link
Contributor

LyonSsS commented Feb 16, 2024

After a first round of QA there are still some issues to be take care of:

  1. Copying the link with page index (Ex: https://feat-use-query-param.explorer-ui-qxq.pages.dev/?page=3) and pasting from a browser to another ( fresh context), the user is always set to the fist page. ( from chrome paste to Opera and Firefox)

image.png

2. The same behavior as above for incognito ( as expected, a new context) 3. When clicking on a transaction detail, and coming back via browser "back" capability or "back" button from scan UI, the indexing page is lost from URL, but context is kept for the correct page.

image.png

4. Empty cache + Hard Refresh - it keeps index on page but lose the actual context on the page and goes to homage ( page 1)

image.png

@wainola
Copy link
Contributor

wainola commented Feb 19, 2024

@LyonSsS point 1 has been fixed. It was fecthing the correct page but it wasn't updating the page number. I'm going to check point 2 and 3.

@LyonSsS
Copy link
Contributor

LyonSsS commented Feb 19, 2024

Retest:

  1. Issue fixed
  2. Issue fixed
    3 Issue fixed, but introduced a new issue for any new tab page of any tx detail

image.png

This is different from https://github.com//issues/154, since here the details are not shown even from the same context page 4. Issue fixed - now it keeps the page context even at clear cache and hard refresh. ( including cache refresh of the entire page app)

@wainola
Copy link
Contributor

wainola commented Feb 19, 2024

@LyonSsS issue 3 is linked to #154 because the same logic should be applied for both. Do I get QA approve for this?

@LyonSsS
Copy link
Contributor

LyonSsS commented Feb 19, 2024

Thanks for clarifying this one @wainola . This issue is now consider as done. The other issue is out of scope to the context of this one.
Closing it.

@LyonSsS LyonSsS closed this as completed Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants