Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Scaling Focal Length when world_scale is not 1 #50

Open
alextrevithick opened this issue Apr 18, 2022 · 0 comments
Open

Bug in Scaling Focal Length when world_scale is not 1 #50

alextrevithick opened this issue Apr 18, 2022 · 0 comments

Comments

@alextrevithick
Copy link

I believe there may be a bug in the data loader for SRN dataset when world_scale is not 1. Specifically, because focal is given in pixels (for example as 131.25), it should not be scaled by world_scale.

To fix this, just delete line 122 in src/data/SRNDataset.py:

if self.world_scale != 1.0:
    focal *= self.world_scale
    all_poses[:, :3, 3] *= self.world_scale

would become

if self.world_scale != 1.0:
    all_poses[:, :3, 3] *= self.world_scale

Thanks for your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant