Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: if input is empty, close it on backspace command #630

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

Rolv-Apneseth
Copy link
Contributor

@Rolv-Apneseth Rolv-Apneseth commented Feb 5, 2024

In relation to #551

Also fixed issue of search being run with nil mentioned in this comment.

Closes #551

@sxyazi
Copy link
Owner

sxyazi commented Feb 6, 2024

Hi, thanks for your PR!

I've made some simplifications - closing input via self.close().

Allowing empty keyword searches is expected behavior, as some users use it to achieve similar functionality to a "flat view". However, displaying nil is indeed a bug, which I've addressed through another method.

@sxyazi sxyazi merged commit fab5bc1 into sxyazi:main Feb 6, 2024
3 checks passed
@sxyazi sxyazi changed the title feat: if prompt is empty, close it on backspace command feat: if input is empty, close it on backspace command Feb 6, 2024
@Rolv-Apneseth
Copy link
Contributor Author

Ah I see, thanks for that

@Rolv-Apneseth Rolv-Apneseth deleted the backspace-exit-prompt branch February 6, 2024 16:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exit popups and the / search with Backspace on empty input like in vim
2 participants