Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make Input and Select positions customizable #361

Merged
merged 16 commits into from
Nov 17, 2023
Merged

feat: make Input and Select positions customizable #361

merged 16 commits into from
Nov 17, 2023

Conversation

Hanaasagi
Copy link
Contributor

@Hanaasagi Hanaasagi commented Nov 12, 2023 •
edited by sxyazi
Loading

@Hanaasagi Hanaasagi marked this pull request as ready for review November 13, 2023 16:07
Hanaasagi
Hanaasagi commented Nov 13, 2023
View reviewed changes
Copy link
Contributor Author

@Hanaasagi Hanaasagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's close. If you have any questions, please comment directly

yazi-core/src/context.rs Outdated Show resolved Hide resolved
yazi-fm/src/completion/completion.rs Outdated Show resolved Hide resolved
yazi-config/preset/yazi.toml Outdated Show resolved Hide resolved
yazi-core/src/manager/commands/quit.rs Outdated Show resolved Hide resolved
yazi-core/src/position.rs Outdated Show resolved Hide resolved
yazi-core/src/tasks/tasks.rs Outdated Show resolved Hide resolved
sxyazi
sxyazi reviewed Nov 13, 2023
View reviewed changes
yazi-config/src/lib.rs Outdated Show resolved Hide resolved
@sxyazi sxyazi changed the title feat: custom input box position feat: make Input and Select component customizable Nov 15, 2023
@sxyazi
Copy link
Owner

sxyazi commented Nov 16, 2023

I've simplified the code, would you like to give it a review?

Hanaasagi
Hanaasagi commented Nov 17, 2023
View reviewed changes
Copy link
Contributor Author

@Hanaasagi Hanaasagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested all the positions, and everything is working as expected! 🎉 thank you.

@sxyazi
Copy link
Owner

sxyazi commented Nov 17, 2023

Awesome, I'm merging it now. Thank you so much for contributing this feature!

@sxyazi sxyazi changed the title feat: make Input and Select component customizable feat: make Input and Select positions customizable Nov 17, 2023
@sxyazi sxyazi merged commit bb2353c into sxyazi:main Nov 17, 2023
3 checks passed
@branchvincent branchvincent mentioned this pull request Jan 15, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sxyazi sxyazi sxyazi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom input box position
2 participants
@Hanaasagi @sxyazi