Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flake.nix #205

Merged
merged 1 commit into from
Sep 22, 2023
Merged

feat: add flake.nix #205

merged 1 commit into from
Sep 22, 2023

Conversation

XYenon
Copy link
Contributor

@XYenon XYenon commented Sep 22, 2023

Close #189

@sxyazi
Copy link
Owner

sxyazi commented Sep 22, 2023

Thank you!

@sxyazi sxyazi merged commit cb13de9 into sxyazi:main Sep 22, 2023
@teto
Copy link

teto commented Sep 22, 2023

This project feels magical, issues get solved almost before being created <3
First good news this works !

A question, would it be better to show the git version here ?

nix run github:sxyazi/yazi -- --version
yazi 0.1.4

or maybe the commit in the version ?

ls -l result
lrwxrwxrwx 1 teto users 52 09-22 14:31 result -> /nix/store/ci5kbaxjndg6jj6ikvcmm1kra8sibjq1-yazi-git

Other question, last time I packaged a rust flake, changing the lockfile was a pain because it required updating a cargoDepsHash in the buildRustPackage call, this doesn't seem to be the case anymore ? (which is a good news).

thanks to you both

@XYenon
Copy link
Contributor Author

XYenon commented Sep 22, 2023

A question, would it be better to show the git version here ?

nix run github:sxyazi/yazi -- --version
yazi 0.1.4

or maybe the commit in the version ?

ls -l result
lrwxrwxrwx 1 teto users 52 09-22 14:31 result -> /nix/store/ci5kbaxjndg6jj6ikvcmm1kra8sibjq1-yazi-git

I have created a pr to add this. And I want to know are there any other optimizations?

Other question, last time I packaged a rust flake, changing the lockfile was a pain because it required updating a cargoDepsHash in the buildRustPackage call, this doesn't seem to be the case anymore ? (which is a good news).

Yeah, I found buildRustPackage can read Cargo.lock directly. I hope other languages can also have this ability.

@teto
Copy link

teto commented Oct 18, 2023

I just tried to launch a nix shell and got

       error: devenv was not able to determine the current directory.
       Make sure Nix runs with the `--impure` 

I have launched hundreds of different nix shells and it's the first time I am asked for the impure flag (admittedly it's the first time I see one using devenv). I think we lose the nixpkgs evaluation cache + reproducibility properties. Isn't there some way we can get rid of devenv ?

@XYenon
Copy link
Contributor Author

XYenon commented Oct 21, 2023

I just tried to launch a nix shell and got

       error: devenv was not able to determine the current directory.
       Make sure Nix runs with the `--impure` 

I have launched hundreds of different nix shells and it's the first time I am asked for the impure flag (admittedly it's the first time I see one using devenv). I think we lose the nixpkgs evaluation cache + reproducibility properties. Isn't there some way we can get rid of devenv ?

I have refactor it to avoid impure, could you give a review?
#293

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add flake.nix to be able to test the master version easily
3 participants