Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add title_format manager config option #1281

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

chriszarate
Copy link
Contributor

@chriszarate chriszarate commented Jul 10, 2024

This PR introduces an update_title manager config option, which controls whether Yazi updates the terminal title using ANSI escape sequences. For some users, this behavior is undesirable since:

  1. Yazi may be invoked within another process (like Vim). If Yazi updates the terminal title, it overrides the title set by / for the parent process.
  2. Users may have their own mechanisms or preferences for setting the terminal title and may not want it overridden.

Apologies that this feature request is a PR and not an issue, but I was eager to experiment with Rust. :) Happy to have it closed in favor of another implementation.

Closes #1350

The `update_title` config option controls whether Yazi updates the
terminal title using ANSI escape sequences. For some users, this
behavior is undesirable since:

1. Yazi may be invoked within another process (like Vim). If Yazi
	 updates the terminal title, it overrides the title set by / for the
	 parent process.
2. Users may have their own mechanisms for setting the terminal title
	 and may not want it overridden.
@SmartFinn
Copy link

It's really nice to have. I just faced with this PR because I was looking how to disable the title update.

@sxyazi sxyazi changed the title Add update_title manager config option feat: add title_format manager config option Aug 2, 2024
Copy link
Owner

@sxyazi sxyazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sxyazi sxyazi merged commit 3533ac2 into sxyazi:main Aug 2, 2024
6 checks passed
@sxyazi sxyazi added this to the v0.3.1 milestone Aug 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide controls over whether the terminal title is updated
3 participants