Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recognize symlink directories as files #125

Merged
merged 1 commit into from
Sep 8, 2023
Merged

fix: recognize symlink directories as files #125

merged 1 commit into from
Sep 8, 2023

Conversation

sxyazi
Copy link
Owner

@sxyazi sxyazi commented Sep 8, 2023

Try to fix #108

@DreamMaoMao
Copy link

DreamMaoMao commented Sep 8, 2023

it work

2023-09-08.22-33-07.mp4

Is it possible that the previous fzf selection skip failure is also caused by this reason? now fzf selection will jump to the directory after the link instead of the current directory. Whether it is necessary to reverse the previous fzf changes

@sxyazi
Copy link
Owner Author

sxyazi commented Sep 8, 2023

It seems unrelated to the previous changes. Previously, we only modified the logic for the watcher, which involved path conversion during cd.

Could you please file a new issue, and let's conclude this one?

@DreamMaoMao
Copy link

ok

@sxyazi sxyazi merged commit c1f3c8f into main Sep 8, 2023
@sxyazi sxyazi deleted the pr-8056b59d branch September 8, 2023 14:44
@sxyazi
Copy link
Owner Author

sxyazi commented Sep 8, 2023

now fzf selection will jump to the directory after the link instead of the current directory

I can't wait for a new issue, so I've already fixed it XD, try #126

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] open a folder with Chinese name and trigger jump fzf to search and select a file, nothing is visible.
2 participants