feat: word wrapping in builtin code preview

[ArtyomArtamonov]

This PR adds a new wrap option under [preview], which can be set to "no" or "yes". When set to "yes", line wrapping is enabled:

# ~/.config/yazi/yazi.toml
[preview]
wrap = "yes"

Note that this feature may still be unstable and its behavior might change in the future because it relies on ratatui's text wrapping implementation, which is itself still unstable, see ratatui/ratatui#293 for details.

[mskvsk]

Thank you for the PR! It works perfectly, the only thing I would change is hard wrap to soft wrap.

Hard wrap example:
The quick brown fox jum
ps over the lazy dog

Soft wrap example:
The quick brown fox
jumps over the lazy dog

As an extra suggestion, the crate I have used previously provides some algorithm that tries to optimize the wrapping so it looks more even. But that's completely optional, just regular soft wrap will be enough.

Appreciate the solution!

[ArtyomArtamonov]

Instead of hard wrap I tried to implement soft wrap. It tries to wrap lines on characters ,.; . If a line does not contain any of these characters, we use the old logic - hard wrapping

[mskvsk]

Works like a charm, thank you.

Please, DM me your Ethereum wallet so I could send you 50 USDT (let me know if you prefer USDC).

As far as I am concerned, the problem is solved so looking forward to @sxyazi 's review.

[sxyazi]

It seems like this branch isn't in the original code - can you explain why you added it?

[ArtyomArtamonov]

Every line in original code had \n at the end, but if we want to wrap long line, we have to place \n at the end of each piece of smaller line. There should not be any issues with old solution because all lines there already have \n at the end

[sxyazi]

Please combine all instances of String::from_utf8 and String::from_utf8_lossy in this function into a single one, as it is a time-consuming operation.

[ArtyomArtamonov]

I tried to optimize this solution a bit by using two buffers: one is string and second is Vec. First one is used only to calculate width every iteration. Second is used to take slices when slicing a line

[sxyazi]

Why do we need both while and for loops here? It seems like while will keep reading until the end of the file without stopping early, I think we should exit the loop as soon as we have enough lines for preview.

Is it possible to move if long_line.is_empty() || lines_handled > skip + area.height as usize { up into the while loop and combine the while and for into one loop?

[ArtyomArtamonov]

At first I thought we have to go line by line twice, but now it seems it's possible to do it once. I tried to refactor code according to this. Now we traverse a file once, like before

[sxyazi]

Suggested change

buf.clear()

This is unnecessary. After mem::take, buf will be initialized as a new Vec.

[ArtyomArtamonov]

done

[sxyazi]

Please keep the original code here. The new implementation using to_string() will cause unnecessary memory reallocations. Since \r\n are known to be ASCII characters, there's no need to treat them as Unicode chars.

[sxyazi]

i.e.

		if line.ends_with("\r\n") {
			line.pop();
			line.pop();
			line.push('\n');

[ArtyomArtamonov]

Fixed

[sxyazi]

Suggested change

	} else if !line.as_str().ends_with('\n') {
	} else if !line.ends_with('\n') {

[ArtyomArtamonov]

also fixed this

[sxyazi]

Thanks!

[plejd-sebman]

It seems that the schema for yazi.toml files haven't been updated with the new wrap option yet. I've tried to find the schema file in this repo but couldn't find it. Where could I find it so that I could create an PR?

[sxyazi]

@plejd-sebman here you go https://github.com/yazi-rs/schemas