Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.4 To-do List #1644

Closed
4 of 5 tasks
sxyazi opened this issue Sep 15, 2024 · 3 comments
Closed
4 of 5 tasks

v0.4 To-do List #1644

sxyazi opened this issue Sep 15, 2024 · 3 comments

Comments

@sxyazi
Copy link
Owner

sxyazi commented Sep 15, 2024

@sxyazi sxyazi added feature New feature request and removed feature New feature request labels Sep 15, 2024
@spenserblack
Copy link

spenserblack commented Oct 31, 2024

Support auto-switching between dark/light flavors

Does this include shipping a preset light flavor to compliment the preset (dark) theme?

I feel I should mention that some light terminal themes invert black and white, and some don't, which can be a bit troublesome. It's a bit of a hack, but it seems that the best way to support light themes is to not use "black" or "white" from the 16 default colors, but instead use the default FG color (AKA "reset"). This is what we did to support light terminals in onefetch.

@sxyazi
Copy link
Owner Author

sxyazi commented Nov 25, 2024

@spenserblack Done in #1946 🎉

@sxyazi sxyazi closed this as completed Dec 5, 2024
@sxyazi sxyazi mentioned this issue Dec 12, 2024
2 tasks
Copy link

github-actions bot commented Jan 4, 2025

I'm going to lock this issue because it has been closed for 30 days. ⏳
This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please file a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants