Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image preview color is incorrect #1599

Closed
TobisLee opened this issue Sep 3, 2024 · 2 comments
Closed

Image preview color is incorrect #1599

TobisLee opened this issue Sep 3, 2024 · 2 comments
Labels
bug Something isn't working upstream

Comments

@TobisLee
Copy link
Contributor

TobisLee commented Sep 3, 2024

What system are you running Yazi on?

Linux Wayland

What terminal are you running Yazi in?

kitty 0.36.1

yazi --debug output

Yazi
    Version: 0.3.2 (e940d81d 2024-09-02)
    Debug  : false
    OS     : linux-x86_64 (unix)

Ya
    Version: 0.3.2 (e940d81d 2024-09-02)

Emulator
    Emulator.via_env: ("xterm-kitty", "")
    Emulator.via_csi: Ok(Kitty)
    Emulator.detect : Kitty

Adapter
    Adapter.matches: Kitty

Desktop
    XDG_SESSION_TYPE           : Some("wayland")
    WAYLAND_DISPLAY            : Some("wayland-0")
    DISPLAY                    : Some(":0")
    SWAYSOCK                   : None
    HYPRLAND_INSTANCE_SIGNATURE: None
    WAYFIRE_SOCKET             : None

SSH
    shared.in_ssh_connection: false

WSL
    WSL: false

Variables
    SHELL              : Some("/usr/bin/fish")
    EDITOR             : Some("nvim")
    VISUAL             : Some("nvim")
    YAZI_FILE_ONE      : None
    YAZI_CONFIG_HOME   : None

Text Opener
    default: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block  : Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })

Multiplexers
    TMUX               : false
    tmux version       : 3.4
    ZELLIJ_SESSION_NAME: None
    Zellij version     : No such file or directory (os error 2)

Dependencies
    file             : 5.45
    ueberzugpp       : 2.9.6
    ffmpegthumbnailer: 2.2.2
    magick           : 7.1.1-38
    fzf              : 0.54.3
    fd               : 10.2.0
    rg               : 14.1.0
    chafa            : 1.14.2
    zoxide           : 0.9.4
    7z               : 17.05
    7zz              : No such file or directory (os error 2)
    jq               : 1.7.1


--------------------------------------------------
When reporting a bug, please also upload the `yazi.log` log file - only upload the most recent content by time.
You can find it in the "/home/tlss/.local/state/yazi" directory.

Did you try the latest nightly build to see if the problem got fixed?

Yes, and I updated the debug information above (yazi --debug) to the nightly that I tried

Describe the bug

The image preview color is not correct. From left to right: in ranger, in gwenview, in yazi. I tested some other images, but none of them are as obvious as this one. I'll put the image down below.
图片

Minimal reproducer

  1. Open the image in yazi
  2. Open the image in other image viewer

Anything else?

Z30_5844_1

@TobisLee TobisLee added the bug Something isn't working label Sep 3, 2024
@TobisLee TobisLee changed the title Image preview looks more yellow than it should be Image preview color is incorrect Sep 3, 2024
@sxyazi
Copy link
Owner

sxyazi commented Sep 3, 2024

I can reproduce it with:

fn main() -> Result<(), ImageError> {
  let image = image::ImageReader::open("original.jpg")?.decode()?;
  image.save("new.jpg")?;

  Ok(())
}

and it's a bug in the image-rs library that Yazi uses, see image-rs/image#2247

We'll have to wait for an upstream fix, I don't think there's anything Yazi can do about it in this situation.

@sxyazi sxyazi closed this as completed Sep 3, 2024
@sxyazi sxyazi added the upstream label Sep 3, 2024
@sxyazi sxyazi closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2024
Copy link

github-actions bot commented Oct 4, 2024

I'm going to lock this issue because it has been closed for 30 days. ⏳
This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working upstream
Projects
None yet
Development

No branches or pull requests

2 participants