Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nil Values #58

Closed
Neilfau opened this issue Apr 8, 2019 · 5 comments
Closed

Nil Values #58

Neilfau opened this issue Apr 8, 2019 · 5 comments
Labels

Comments

@Neilfau
Copy link

Neilfau commented Apr 8, 2019

Ive noticed since updating to the latest version a lot of values are now nil all the time. All the precipitation values, temperatures low/high etc. Some data is being decoded but not all of it.

@sxg
Copy link
Owner

sxg commented Apr 8, 2019

Ah damn. I thought things were ok with the unit tests. I’ll take a look at this later this evening and try to submit an update ASAP.

@Neilfau
Copy link
Author

Neilfau commented Apr 8, 2019

Ok thanks!

@sxg
Copy link
Owner

sxg commented Apr 8, 2019

I'm currently working on this, and I realized that the JSON keys for some of the precipitation values differ from the property names I specified, which explains that issue. Are you seeing other data that exists in the JSON but not in ForecastIO? I'm searching for other errors but not coming up with much.

Additionally, Flag.nearestStation is not always included in the JSON response despite DarkSky's API noting it as a required property. I'll reach out to them and see if that's a documentation or service bug.

@Neilfau
Copy link
Author

Neilfau commented Apr 9, 2019

I think it was mainly precipitation and temperature high / lows were the main problem, but I didn't have time to investigate into too much detail.

@sxg
Copy link
Owner

sxg commented Apr 9, 2019

I checked the temperature values, and I was able to confirm that those fields are being populated. They are optional properties, so they may not always be there on all requests. The main issue I saw was with the precipitation properties, which are now fixed in 6.0.1. Let me know if you run into more discrepancies between the JSON response and ForecastIO, and thanks for bringing this to my attention!

@sxg sxg closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants