Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install @swup/cli fails at node-gyp rebuild #15

Closed
2 tasks done
hirasso opened this issue Mar 6, 2022 · 3 comments
Closed
2 tasks done

npm install @swup/cli fails at node-gyp rebuild #15

hirasso opened this issue Mar 6, 2022 · 3 comments
Labels
dependencies Pull requests that update a dependency file question Further information is requested

Comments

@hirasso
Copy link
Member

hirasso commented Mar 6, 2022

Describe your issue:
Hi there! Just wanted to take the CLI for a spin, but I can't install it. When I run npm install @swup/cli, either globally or locally, I always get this error:

npm ERR! code 1
npm ERR! command failed
npm ERR! command sh -c node-gyp rebuild
[...more verbose stuff...]

My node version is v14.18.1 and the current package.json of node-gyp looks like it should be compatible. Maybe there is an outdated package in the swup cli dependencies that causes the issue? There are quite a few deprecated warnings before the error occurs:

npm WARN deprecated [email protected]: this library is no longer supported
npm WARN deprecated [email protected]: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated [email protected]: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated [email protected]: This module has moved and is now available at @hapi/hoek. Please update your dependencies as this version is no longer maintained an may contain bugs and security issues.
npm WARN deprecated [email protected]: This module has moved and is now available at @hapi/topo. Please update your dependencies as this version is no longer maintained an may contain bugs and security issues.
npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated [email protected]: Version no longer supported. Upgrade to @latest

Before creating this issue, did you think of...:

  • Have you checked closed issues for similar/related problems.
  • Have you provided all helpful information available?

I saw that there are quite a few version bump pull requests waiting to be merged, maybe this already would solve this issue?

@daun daun added bug Something isn't working needs investigating labels Jun 3, 2022
@daun
Copy link
Member

daun commented Jun 3, 2022

Can confirm the install is failing. This seems to be an issue with the xml parser in use, node-xml2json. Switching to another parser like xml-js might help.

@daun
Copy link
Member

daun commented Aug 7, 2022

@hirasso For some reason, it now works fine on my laptop while it recently failed on my desktop machine. Both running MacOS, but on different versions. What OS are you on?

$ swup -v
@swup/cli/4.0.3 darwin-x64 node-v14.17.6

@hirasso
Copy link
Member Author

hirasso commented Aug 7, 2022

Thanks for trying it again! You motivated me to dig a little deeper. I'm also on a MAC, with MAMP installed. I noticed that libtool was having trouble. Following the advice found here, I copied over the libtool binary from /usr/bin over to /Applications/MAMP/Library/bin, overwriting the version in there.

After that the CLI installed without Errors! 🎉

$ swup -v
@swup/cli/4.0.3 darwin-x64 node-v14.18.1

@hirasso hirasso closed this as completed Aug 7, 2022
@hirasso hirasso added question Further information is requested dependencies Pull requests that update a dependency file and removed bug Something isn't working needs investigating labels Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants