Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent post-tabs from firing a change event on init #2872

Closed
oliverschuerch opened this issue Apr 2, 2024 · 0 comments · Fixed by #3247
Closed

Prevent post-tabs from firing a change event on init #2872

oliverschuerch opened this issue Apr 2, 2024 · 0 comments · Fixed by #3247
Assignees
@alizedebray
Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package

Comments

@oliverschuerch
Copy link
Contributor

The post-tabs component is firing a postChange event on componentDidLoad. This is wrong and should not happen.
Change events should only be triggerd on a change not on init.
@oliverschuerch oliverschuerch added 🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package labels Apr 2, 2024
@github-actions github-actions bot added the stale label Jul 1, 2024
@gfellerph gfellerph removed the stale label Jul 3, 2024
@gfellerph gfellerph moved this from 🗃️ Ready for work to 👀 Triage in Design System Production Board Jul 3, 2024
@gfellerph gfellerph moved this from 👀 Triage to 🗃️ Ready for work in Design System Production Board Jul 9, 2024
@alizedebray alizedebray self-assigned this Jul 10, 2024
@alizedebray alizedebray moved this from 🗃️ Ready for work to 🕹️ Coding in progress in Design System Production Board Jul 10, 2024
@alizedebray alizedebray linked a pull request Jul 10, 2024 that will close this issue
fix(components): prevent postChange event emitting before post-tabs loads #3247
Merged
@alizedebray alizedebray moved this from 🕹️ Coding in progress to 🤬 Dev in review in Design System Production Board Jul 10, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in review to 🚀 Done in Design System Production Board Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alizedebray alizedebray

Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package
Projects
Design System Production Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(components): prevent postChange event emitting before post-tabs loads swisspost/design-system
3 participants
@gfellerph @oliverschuerch @alizedebray