Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styles for prime ng datatable #2069

Closed
2 tasks
gfellerph opened this issue Oct 12, 2023 · 1 comment · Fixed by #2718
Closed
2 tasks

Styles for prime ng datatable #2069

gfellerph opened this issue Oct 12, 2023 · 1 comment · Fixed by #2718
Assignees
@alizedebray
Labels
🦌 fair game This issue can potentially be closed because it no longer fits into the ecosystem request 📦 styles Related to the @swisspost/design-system-styles package

Comments

@gfellerph
Copy link
Member

gfellerph commented Oct 12, 2023 •
edited
Loading

People are using this component in internal projects and we could provide styles for it: https://primeng.org/table.

Tasks
Beta Give feedback
@gfellerph gfellerph added 📦 styles Related to the @swisspost/design-system-styles package request labels Oct 12, 2023
@imagoiq imagoiq added this to the November 2023 milestone Oct 17, 2023
@imagoiq imagoiq self-assigned this Nov 8, 2023
@imagoiq imagoiq moved this from 📋 Backlog to 🏗 In progress in Design System Production Board Nov 8, 2023
@gfellerph
Copy link
Member Author

gfellerph commented Nov 22, 2023 •
edited
Loading

  • Prime Ng Style generator could be an option
  • Create our own?
  • How final would this implementation be?
  • Could create a standalone page and use iframes to display the component in storybook. But what about snapshots?
  • Could we use angular-elements?
  • Use the style creator and document with an image?

@imagoiq imagoiq removed their assignment Nov 22, 2023
@imagoiq imagoiq moved this from 🏗 In progress to 🔖 Ready in Design System Production Board Nov 22, 2023
@imagoiq imagoiq moved this from 🔖 Ready to 📋 Backlog in Design System Production Board Nov 22, 2023
@imagoiq imagoiq removed this from the November 2023 milestone Nov 23, 2023
@alizedebray alizedebray self-assigned this Feb 16, 2024
@alizedebray alizedebray moved this from 📋 Backlog to 🏗 In progress in Design System Production Board Feb 19, 2024
@alizedebray alizedebray moved this from 🏗 In progress to 👀 In review in Design System Production Board Feb 28, 2024
@oliverschuerch oliverschuerch moved this from Design in review to Development in code review in Design System Production Board Apr 23, 2024
@alizedebray alizedebray linked a pull request Apr 29, 2024 that will close this issue
feat(styles): add custom theme for primeng #2718
Merged
@github-actions github-actions bot added the stale label May 16, 2024
@gfellerph gfellerph removed the stale label May 27, 2024
@gfellerph gfellerph added the 🦌 fair game This issue can potentially be closed because it no longer fits into the ecosystem label Jul 15, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in review to 🚀 Done in Design System Production Board Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alizedebray alizedebray

Labels
🦌 fair game This issue can potentially be closed because it no longer fits into the ecosystem request 📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(styles): add custom theme for primeng swisspost/design-system
3 participants
@gfellerph @imagoiq @alizedebray