Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map GLintptr IDL type to Swift Int32 #42

Merged
merged 4 commits into from
May 12, 2022
Merged

Map GLintptr IDL type to Swift Int32 #42

merged 4 commits into from
May 12, 2022

Commits on May 12, 2022

  1. Map long long IDL type to Swift Int32 

    This fixes an issue with `func vertexAttribPointer(index: GLuint, size: GLint, type: GLenum, normalized: GLboolean, stride: GLsizei, offset: GLintptr)` passing `offset` value of `BigInt` type to the JS function due to `public typealias GLintptr = Int64`, which led to `can't cast BigInt to number` runtime errors.

Either WebGL spec is wrong, or browsers implement it incorrectly. Rust folks had a similar issue and they went with `i32`.
    @MaxDesiatov
    MaxDesiatov committed May 12, 2022
    Configuration menu
    Copy the full SHA
    ff09330 View commit details
    Browse the repository at this point in the history

  2. Declare GLintptr typealias manually

    @MaxDesiatov
    MaxDesiatov committed May 12, 2022
    Configuration menu
    Copy the full SHA
    90de29e View commit details
    Browse the repository at this point in the history

  3. Revert untested Int32 changes

    @MaxDesiatov
    MaxDesiatov committed May 12, 2022
    Configuration menu
    Copy the full SHA
    dda1e7b View commit details
    Browse the repository at this point in the history

  4. Expand GLintptr comment

    @MaxDesiatov
    MaxDesiatov committed May 12, 2022
    Configuration menu
    Copy the full SHA
    3a15035 View commit details
    Browse the repository at this point in the history