[stdlib] Changes to support Foundation on OpenBSD. #38341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Not implementing POSIXError for a given platform is not a blocking problem to getting a successful build of Swift. However, it is part of the validation tests (albeit locked behind REQUIRES) and is referenced when building Foundation. Implement by forklifting from `sys/errno.h`. * Some Foundation class implementations require some missing includes in the platform modulemap. Add these.
finagolfin
reviewed
Jul 10, 2021
finagolfin
approved these changes
Jul 10, 2021
|
@compnerd do you mind reviewing and merging if you approve, or in the alternative, tagging someone who would be best suited to do so? |
|
ping. |
|
ping |
|
@spevans, would you review? |
|
@swift-ci test |
|
Anything else left to be done here to merge? |
|
ping |
|
I think there might be a crunch for the upcoming Swift 5.5 and iPhone 13 releases, so we may have to wait a bit. |
|
@kubamracek, mind getting this in? |
compnerd
approved these changes
Dec 11, 2021
|
@swift-ci please smoke test and merge |
|
Yeah, we'll look at moving towards the single-header module outside this pr. |
3405691582
added a commit
to 3405691582/swift
that referenced
this pull request
Feb 11, 2022
This migrates OpenBSD to use the single-header Glibc modulemap proposed and implemented in swiftlang#32404, and necessitates introducing some missing headers for building Foundation added in swiftlang#38341. Additionally, incorporate nullability annotations in SwiftShims per
finagolfin
pushed a commit
to finagolfin/swift
that referenced
this pull request
Feb 22, 2022
This migrates OpenBSD to use the single-header Glibc modulemap proposed and implemented in swiftlang#32404, and necessitates introducing some missing headers for building Foundation added in swiftlang#38341. Additionally, incorporate nullability annotations in SwiftShims per
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not implementing POSIXError for a given platform is not a blocking
problem to getting a successful build of Swift. However, it is
part of the validation tests (albeit locked behind REQUIRES) and is
referenced when building Foundation. Implement by forklifting from
sys/errno.h.Some Foundation class implementations require some missing includes in
the platform modulemap. Add these.