Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Remove remaining dependencies on libatomic, for Android, BSD and Haiku #34757

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

finagolfin
Copy link
Member

Follow suit from linux, #29581, tested on Android.

@drodriguez, spun this off from earlier unmerged pulls, as you asked.

…and Haiku

Follow suit from linux, swiftlang#29581, tested on Android.
@drodriguez
Copy link
Contributor

@swift-ci please smoke test

Copy link
Contributor

@drodriguez drodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked in a local setup close to the Android CI builders. It seems to not create any new build problems.

Good to merge for me.

@drodriguez
Copy link
Contributor

@swift-ci please test Windows platform

@drodriguez
Copy link
Contributor

drodriguez commented Nov 17, 2020

@swift-ci please test Windows platform

Edit: this one has started in -05, which is hopefully not out of disk space. The previous 2 were in -03, which is failing because disk space.

@drodriguez drodriguez merged commit 36090fa into swiftlang:main Nov 17, 2020
@finagolfin finagolfin deleted the atomic branch November 17, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants