Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sema/stdlib] Use @_implements to avoid source breakage in conditional conformances #14536

Merged
merged 1 commit into from
Feb 11, 2018
Merged

[Sema/stdlib] Use @_implements to avoid source breakage in conditional conformances #14536

merged 1 commit into from
Feb 11, 2018

Conversation

xwu
Copy link
Collaborator

@xwu xwu commented Feb 11, 2018

This PR take a different tack to avoiding source breakage. Let's see if it works.

@xwu
Copy link
Collaborator Author

xwu commented Feb 11, 2018

@swift-ci Please smoke test OS X platform

@xwu
Copy link
Collaborator Author

xwu commented Feb 11, 2018

@swift-ci Please clean smoke test OS X platform

@xwu
Copy link
Collaborator Author

xwu commented Feb 11, 2018

cc @lorentey

@xwu
Copy link
Collaborator Author

xwu commented Feb 11, 2018

Looks like I can't test off of a branch, but I think this is the general solution (and the reason @_implements exists in the first place).

@xwu xwu merged commit b5a1d4b into swiftlang:conditional-hashable Feb 11, 2018
@xwu xwu deleted the conditional-hashable-at-implements branch February 11, 2018 06:27
xwu added a commit that referenced this pull request Feb 11, 2018
@xwu
Revert "Merge pull request #14536 from xwu/conditional-hashable-at-im…
9b5c23c 
…plements"

This reverts commit b5a1d4b, reversing
changes made to d03f0b3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xwu