Update for SE-0055: Making pointer nullability explicit #232
Conversation
|
@mxcl or someone else, would you mind reviewing? |
| try body(fp) | ||
| fclose(fp) // defer is not necessarily immediate |
There was a problem hiding this comment.
defer will always happen at the end of the scope (close-brace), just like a C++ destructor. It can get moved around by optimization, but so can everything else.
There was a problem hiding this comment.
Without this I was having the file write not be flushed sometimes before we tried to use it.
There was a problem hiding this comment.
I really don't think that should happen…or rather, I can't think of any way that would happen that wouldn't do the same thing with the manual invocation.
There was a problem hiding this comment.
I can believe there's a bug, though.
There was a problem hiding this comment.
K, well let's remove it then and if we see the behavior I described we will investigate further.
jrose-apple
force-pushed
the
optional-pointers
branch
from
f187d68 to
a1c098d
Compare
|
LGTM though we may want to avoid the removal of that defer. |
jrose-apple
force-pushed
the
optional-pointers
branch
from
a1c098d to
c062bee
Compare
jrose-apple
force-pushed
the
optional-pointers
branch
from
c062bee to
442f62a
Compare
See swiftlang/swift#1878. Note: this needs a coordinated merge, i.e. it must go in ASAP after that request!