Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark tool to same macOS version as DocC #1124

Merged

Conversation

d-ronnqvist
Copy link
Contributor

@d-ronnqvist d-ronnqvist commented Dec 10, 2024

Bug/issue #, if applicable: rdar://141185270

Summary

This updates the benchmark tool to require the same macOS version as DocC.

Dependencies

None

Testing

Run any command with the benchmark tool, as described in Benchmarking.md

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran the ./bin/test script and it succeeded
  • Updated documentation if necessary

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist d-ronnqvist merged commit cffe76c into swiftlang:main Dec 10, 2024
2 checks passed
@d-ronnqvist d-ronnqvist deleted the update-benchmark-tool-platforms branch December 10, 2024 10:46
d-ronnqvist added a commit to d-ronnqvist/swift-docc that referenced this pull request Dec 10, 2024
d-ronnqvist added a commit that referenced this pull request Dec 10, 2024
* Wrap various convert subtasks in signpost intervals (#1112)

rdar://141210010

* Add a no-op shim for os.OSSignpost

* Bump platform versions to be able to use OSSignposter

* Fix deprecation warnings about UTType API

* Wrap various major convert tasks in signpost intervals

* Add a no-op shim for os.Logger

* Add support for interpolating errors in no-op log messages

* Address code review feedback:

- Add signpost intervals around a few more tasks

* Update benchmark tool to same macOS version as DocC (#1124)

rdar://141185270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants