Regression: Link to swc-windows-installer.py in gh-pages points to master

[gdevenyi]

Since master has transitioned to the full-fledged installer, the swc-windows-installer.py link in gh-pages goes nowhere, which breaks upcoming bootcamps.

I think the file should be put back and gh-pages fixed to point to it's local copy rather than swc master github copy.

[wking]

On Wed, May 21, 2014 at 07:56:34AM -0700, Gabriel A. Devenyi wrote:

Since master has transitioned to the full-fledged installer, the
swc-windows-installer.py link in gh-pages goes nowhere, which breaks
upcoming bootcamps.

Related to #496, but that's about the link from files.s-c.o.

I think the file should be put back and gh-pages fixed to point to
it's local copy rather than swc master github copy.

The file is still there, just down one level:

https://github.com/swcarpentry/bc/blob/master/setup/windows-installer/swc-windows-installer.py

A relative link to the local copy in gh-pages would be more robust
though.

[gdevenyi]

Agreed, fixing the link in gh-pages is the proper solution, but what about all the book camp pages that are already created and sitting there, and an attendee finds a 404?

[wking]

On Wed, May 21, 2014 at 08:33:51AM -0700, Gabriel A. Devenyi wrote:

Agreed, fixing the link in gh-pages is the proper solution, but what
about all the book camp pages that are already created and sitting
there, and an attendee finds a 404?

It looks like the CSDMS workshop (May 23rd) is the only workshop
before the end of the month 1. They don't mention the
swc-windows-installer.py script in their setup instructions 2. For
later workshops like Monash [3](June 2nd), we should have time to
land a hotfix commit in gh-pages which they can merge. Unfortunately,
our gh-pages release/deploy process is a bit flaky, so it's hard to
know where to base the fixup commit. For example Monash branches off
from gh-pages two commits before v2014.04. If we release a v2014.04.1
based on 2014.04, they'll have to pull in c3a7f69 (Merge pull request
#388 from stevenkoenig/fix-readme-info-gfx) and 5367015 (Add link to
older installers for Git for OS X) as well (or cherry-pick). Tracking
down the branch-point for all the outstanding workshops would be
difficult.

For this particular case, it may be best to temporarily restore the
un-namespaced script and leave it for a few months (until any
already-forked workshops have passed). We can reduce the changes of
similar problems in the future by avoiding external links, cutting
more frequent releases, and encouraging folks to branch off releases
instead of arbitrary gh-pages commits.

[gdevenyi]

I came across this because I'm running a bootcamp at cornell
https://github.com/gdevenyi/2014-06-04-cornell

Which exhibited the bug as well

[wking]

On Wed, May 21, 2014 at 08:51:45AM -0700, Gabriel A. Devenyi wrote:

I came across this because I'm running a bootcamp at cornell
https://github.com/gdevenyi/2014-06-04-cornell

Which exhibited the bug as well

It looks like you've branched off the current gh-pages tip at f6ab445
(Merge pull request #465 from gvwilson/gh-pages, 2014-04-27), so
anything that lands anywhere in gh-pages would work for you.
Alternatively, it would be pretty easy to fix your two references
locally:

$ git grep swc-windows-installer 2014-06-04-cornell/gh-pages
2014-06-04-cornell/gh-pages:_includes/setup.html: Download the installer.
2014-06-04-cornell/gh-pages:lessons/setup.html: Download the installer.

without waiting for an upstream fix in this repo. The simplest fix
would be absolute links to
https://raw.githubusercontent.com/gdevenyi/2014-06-04-cornell/gh-pages/setup/swc-windows-installer.py

[gdevenyi]

Yeah, I already fixed it, just reporting for others.

[wking]

On Wed, May 21, 2014 at 09:15:30AM -0700, Gabriel A. Devenyi wrote:

Yeah, I already fixed it, just reporting for others.

Did you forget to push your fix? It looks like your public gh-pages
branch is still using the broken URL in lessons/setup.html:

$ git remote -v | grep 2014-06-04-cornell
2014-06-04-cornell git://github.com/gdevenyi/2014-06-04-cornell.git (fetch)
2014-06-04-cornell git://github.com/gdevenyi/2014-06-04-cornell.git (push)
$ git fetch 2014-06-04-cornell
$ git show-ref 2014-06-04-cornell/gh-pages
17952b3eedaa1022da02dbdf4d3d10f98197d057 refs/remotes/2014-06-04-cornell/gh-pages
$ git grep swc-windows-installer 2014-06-04-cornell/gh-pages
2014-06-04-cornell/gh-pages:_includes/setup.html: Download the installer.
2014-06-04-cornell/gh-pages:lessons/setup.html: Download the installer.

[gdevenyi]

I changed the link to point to bc/gh-pages assuming that file would be there for a while I would hope.

lessons/setup.html isn't exposed anywhere so I didn't bother

[wking]

On Wed, May 21, 2014 at 09:40:16AM -0700, Gabriel A. Devenyi wrote:

I changed the link to point to bc/gh-pages assuming that file would
be there for a while I would hope.

Probably a safe bet now that you've pointed out this issue, but it
would be better to use a local link 1. Then you wouldn't need to
hope at all, other than hoping that GitHub stays up ;).

lessons/setup.html isn't exposed anywhere so I didn't bother

Fair enough.

[bkatiemills]

This broke the Claremont bootcamp pages too, the host just pointed it out; hacking in the local link per above solves the problem for now.