Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate OpenRefine: Setup #154

Merged
merged 7 commits into from
Oct 3, 2021
Merged

Translate OpenRefine: Setup #154

merged 7 commits into from
Oct 3, 2021

Conversation

kozo2
Copy link
Collaborator

@kozo2 kozo2 commented Jul 30, 2021

See also #151

@kozo2 kozo2 requested review from masamiy and naganeayu July 30, 2021 21:16
@kozo2 kozo2 mentioned this pull request Jul 30, 2021
Closed
@masamiy
Copy link
Collaborator

masamiy commented Aug 1, 2021

Thanks @kozo2 , I will have a look by the end of next week.

masamiy
masamiy requested changes Aug 9, 2021
View reviewed changes
Copy link
Collaborator

@masamiy masamiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kozo for your translation! I think it is good. Please add a small space between alphabet and Japanese characters throughout the lesson. Other than that, I left a few suggestions. Please have a look.

po/lc-open-refine.ja.po Outdated Show resolved Hide resolved
po/lc-open-refine.ja.po Outdated Show resolved Hide resolved
po/lc-open-refine.ja.po Outdated Show resolved Hide resolved
po/lc-open-refine.ja.po Outdated Show resolved Hide resolved
po/lc-open-refine.ja.po Outdated Show resolved Hide resolved
@kozo2
Copy link
Collaborator Author

kozo2 commented Aug 14, 2021

@masamiy I have reflected all the changes you requested in the po file.

masamiy
masamiy approved these changes Aug 21, 2021
View reviewed changes
Copy link
Collaborator

@masamiy masamiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kozo!

@joelnitta joelnitta linked an issue Oct 2, 2021 that may be closed by this pull request
Translation: Library Carpentry OpenRefine "Setup" #151
Closed
@mergify mergify bot merged commit fa0c797 into swcarpentry-ja:ja Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masamiy masamiy masamiy approved these changes

@joelnitta joelnitta joelnitta left review comments

@naganeayu naganeayu naganeayu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translation: Library Carpentry OpenRefine "Setup"
4 participants
@kozo2 @masamiy @joelnitta @naganeayu