Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation of Git episode 5 #135

Merged
merged 29 commits into from
Nov 30, 2021
Merged

Translation of Git episode 5 #135

merged 29 commits into from
Nov 30, 2021

Conversation

kozo2
Copy link
Collaborator

@kozo2 kozo2 commented Nov 7, 2020

No description provided.

@TomKellyGenetics
Copy link
Member

お疲れ様でした。

@TomKellyGenetics TomKellyGenetics linked an issue Nov 7, 2020 that may be closed by this pull request
Translation: git-novice Episode 5 #65
Closed
TomKellyGenetics
TomKellyGenetics reviewed Nov 15, 2020
View reviewed changes
Copy link
Member

@TomKellyGenetics TomKellyGenetics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note we don't need to change the headings.

po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
@kozo2 kozo2 marked this pull request as ready for review November 22, 2020 19:14
@kozo2 kozo2 changed the title Translate git novice episode5 Translation of Git episode5 Nov 22, 2020
@kozo2 kozo2 changed the title Translation of Git episode5 Translation of Git episode 5 Nov 22, 2020
@TomKellyGenetics
Copy link
Member

@kozo2 is this one ready to check? It looks like this is a full lesson. 🎉

@kozo2
Copy link
Collaborator Author

kozo2 commented Dec 8, 2020

@TomKellyGenetics Yes, I would like to ask you to check. Thank you.

@joelnitta joelnitta self-requested a review August 2, 2021 06:11
joelnitta
joelnitta reviewed Oct 31, 2021
View reviewed changes
Copy link
Member

@joelnitta joelnitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Please see my comments and suggestions.

po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
@kozo2
Copy link
Collaborator Author

kozo2 commented Nov 30, 2021

I resolved all review comments except that there is no original English text for "Solution".

@joelnitta
Copy link
Member

Thanks! Let's merge this and file that as an issue to fix later then.

@mergify mergify bot merged commit ed0d672 into swcarpentry-ja:ja Nov 30, 2021
@TomKellyGenetics
Copy link
Member

@joelnitta @kozo2
I've looked into the missing "solutions" issue. I've checked the original lesson and could not find that text in the git-novice.ja.po. It seems these solutions were not included in our English version either. It's unclear to me whether our English version is simply outdated or the hidden solution feature isn't supported in our theme/po4gitbook workflow.

Anyway well done on getting the lesson translated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelnitta joelnitta joelnitta approved these changes

@TomKellyGenetics TomKellyGenetics TomKellyGenetics approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translation: git-novice Episode 5
3 participants
@kozo2 @TomKellyGenetics @joelnitta