Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Track if a var is used with in #9508

Merged
merged 3 commits into from
Aug 28, 2024
Merged

fix(es/minifier): Track if a var is used with in #9508

merged 3 commits into from
Aug 28, 2024
+20 −0

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 28, 2024

@kdy1 kdy1 added this to the Planned milestone Aug 28, 2024
@kdy1 kdy1 self-assigned this Aug 28, 2024
@kdy1 kdy1 requested a review from a team as a code owner August 28, 2024 00:54
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7b9dfed

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 28, 2024
View reviewed changes
@Austaras
Copy link
Member

Maybe just reuse used_as_ref?

Austaras
Austaras requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@Austaras Austaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 28, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9508 will not alter performance

Comparing kdy1:issue-9499 (7b9dfed) with main (da52930)

Summary

✅ 178 untouched benchmarks

kdy1
kdy1 commented Aug 28, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try if the output is identical

kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 28, 2024
View reviewed changes
@kdy1 kdy1 requested a review from a team as a code owner August 28, 2024 03:07
@kdy1 kdy1 requested a review from Austaras August 28, 2024 03:14
@kdy1 kdy1 merged commit 7d6269e into swc-project:main Aug 28, 2024
152 of 154 checks passed
@kdy1 kdy1 deleted the issue-9499 branch August 28, 2024 04:32
@kdy1 kdy1 modified the milestones: Planned, v1.7.19 Aug 28, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

@Austaras Austaras Austaras approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.7.19
Development

Successfully merging this pull request may close these issues.

Minifier removes object used in rhs of in operator
2 participants
@kdy1 @Austaras