Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(visit): Add experimental traverse APIs #9464

Merged
merged 9 commits into from
Aug 20, 2024
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 20, 2024

Description:

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Aug 20, 2024
@kdy1 kdy1 self-assigned this Aug 20, 2024
Copy link

changeset-bot bot commented Aug 20, 2024

🦋 Changeset detected

Latest commit: 5a553e5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Aug 20, 2024

CodSpeed Performance Report

Merging #9464 will degrade performances by 3.51%

Comparing kdy1:visit-order (5a553e5) with main (8c007c4)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 175 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:visit-order Change
es/full/bugs-1 531.7 µs 551 µs -3.51%
es/full/codegen/es2015 290.2 µs 275.5 µs +5.34%
es/visitor/base-perf/boxing_unboxed_clone 2.6 µs 2.5 µs +3.48%

@kdy1 kdy1 changed the title feat(visit): Add preorder/postorder traversal feat(visit): Add NodeRef::traverse Aug 20, 2024
@kdy1 kdy1 marked this pull request as ready for review August 20, 2024 23:00
@kdy1 kdy1 requested review from a team as code owners August 20, 2024 23:00
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 20, 2024
@kdy1 kdy1 changed the title feat(visit): Add NodeRef::traverse feat(visit): Add experimental traverse APIs Aug 20, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 20, 2024
@kdy1 kdy1 enabled auto-merge (squash) August 20, 2024 23:01
@kdy1 kdy1 disabled auto-merge August 20, 2024 23:29
@kdy1 kdy1 merged commit 3ee8980 into swc-project:main Aug 20, 2024
153 checks passed
@kdy1 kdy1 deleted the visit-order branch August 20, 2024 23:29
@kdy1 kdy1 modified the milestones: Planned, v1.7.17 Aug 23, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant