Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/plugin): Revert #9696 #9717

Merged
merged 2 commits into from
Nov 6, 2024
Merged

fix(es/plugin): Revert #9696 #9717

merged 2 commits into from
Nov 6, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 6, 2024

No description provided.

@kdy1 kdy1 added this to the Planned milestone Nov 6, 2024
@kdy1 kdy1 self-assigned this Nov 6, 2024
@kdy1 kdy1 requested a review from a team as a code owner November 6, 2024 02:23
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 6, 2024
Copy link

changeset-bot bot commented Nov 6, 2024

🦋 Changeset detected

Latest commit: eede318

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 enabled auto-merge (squash) November 6, 2024 02:25
Copy link

codspeed-hq bot commented Nov 6, 2024

CodSpeed Performance Report

Merging #9717 will degrade performances by 7.93%

Comparing kdy1:revert (eede318) with main (6194044)

Summary

⚡ 1 improvements
❌ 9 regressions
✅ 184 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:revert Change
es/full/all/es2015 183.6 ms 191.9 ms -4.34%
es/full/all/es2016 182.4 ms 190.3 ms -4.16%
es/full/all/es2017 181.5 ms 189.7 ms -4.31%
es/full/all/es2018 180.1 ms 188.1 ms -4.21%
es/full/all/es2019 179.2 ms 187.2 ms -4.26%
es/full/all/es2020 172.3 ms 180.5 ms -4.57%
es/full/all/es3 248 ms 256.3 ms -3.23%
es/full/all/es5 241.2 ms 249.8 ms -3.44%
es/full/parser 1.4 ms 1.5 ms -7.93%
es/visitor/base-perf/boxing_unboxed_clone 2.6 µs 2.5 µs +3.47%

@kdy1 kdy1 disabled auto-merge November 6, 2024 06:26
@kdy1 kdy1 merged commit 772f023 into swc-project:main Nov 6, 2024
149 of 153 checks passed
@kdy1 kdy1 deleted the revert branch November 6, 2024 06:26
@kdy1 kdy1 modified the milestones: Planned, v1.9.0 Nov 6, 2024
kdy1 added a commit to kdy1/swc that referenced this pull request Nov 11, 2024
kdy1 added a commit that referenced this pull request Nov 11, 2024
**Description:**

This reverts commit 772f023.

**Related issue:**

 - Reverts #9717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant