Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindings/html): Accept Buffer|string instead of Buffer #9625

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 8, 2024

Description:

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Oct 8, 2024
@kdy1 kdy1 self-assigned this Oct 8, 2024
@kdy1 kdy1 requested a review from a team as a code owner October 8, 2024 06:35
Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: 355bca9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 changed the title feat(bindings/html): Accept Buffer | string instead of Buffer feat(bindings/html): Accept Buffer|string instead of Buffer Oct 8, 2024
@kdy1 kdy1 merged commit 62edb36 into swc-project:main Oct 8, 2024
23 of 24 checks passed
@kdy1 kdy1 deleted the html-api branch October 8, 2024 06:35
Copy link

codspeed-hq bot commented Oct 8, 2024

CodSpeed Performance Report

Merging #9625 will degrade performances by 5.78%

Comparing kdy1:html-api (355bca9) with main (6a3b0fc)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 191 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:html-api Change
es/full/bugs-1 501.6 µs 532.4 µs -5.78%
es/full/base/fixer 122.8 µs 118.6 µs +3.55%
es/visitor/base-perf/boxing_boxed_clone 2.3 µs 2.4 µs -3.63%

@kdy1
Copy link
Member Author

kdy1 commented Oct 8, 2024

@slorber Once it's published, @swc/html will accept string | Buffer for minify* APIs. I'll fix the publish pipeline asap and publish a new version soon.

@slorber
Copy link
Contributor

slorber commented Oct 8, 2024

Thanks :)

@kdy1 kdy1 modified the milestones: Planned, v1.7.33 Oct 10, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants