Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Compress consecutive return statements properly #9620

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

canalun
Copy link
Contributor

@canalun canalun commented Oct 7, 2024

Description:

Compress consecutive return statements properly.

BREAKING CHANGE:
None. All the existing cases passed.

Related issue:
#9619

@canalun canalun requested a review from a team as a code owner October 7, 2024 17:05
Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: 3378674

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codspeed-hq bot commented Oct 7, 2024

CodSpeed Performance Report

Merging #9620 will degrade performances by 4.07%

Comparing canalun:issue/9619 (3378674) with main (7b98bb5)

Summary

❌ 1 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main canalun:issue/9619 Change
es/full/bugs-1 511.4 µs 533.1 µs -4.07%

@kdy1 kdy1 added this to the Planned milestone Oct 7, 2024
@kdy1 kdy1 requested a review from a team as a code owner October 7, 2024 22:57
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdy1 kdy1 changed the title fix: compress consecutive return statements properly fix(es/minifier): Compress consecutive return statements properly Oct 7, 2024
@kdy1 kdy1 merged commit 8263da1 into swc-project:main Oct 7, 2024
24 checks passed
@canalun canalun deleted the issue/9619 branch October 8, 2024 01:02
@canalun
Copy link
Contributor Author

canalun commented Oct 8, 2024

Thank you for quick response!

@kdy1 kdy1 modified the milestones: Planned, v1.7.31 Oct 8, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants