Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/typescript): Fix typings #9301

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@magic-akari magic-akari requested a review from a team as a code owner July 20, 2024 14:36
Copy link

changeset-bot bot commented Jul 20, 2024

⚠️ No Changeset found

Latest commit: f201950

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codspeed-hq bot commented Jul 20, 2024

CodSpeed Performance Report

Merging #9301 will improve performances by 3.77%

Comparing magic-akari:wasm-typescript/type (f201950) with main (567f40d)

Summary

⚡ 1 improvements
✅ 177 untouched benchmarks

Benchmarks breakdown

Benchmark main magic-akari:wasm-typescript/type Change
es/visitor/base-perf/boxing_boxed_clone 2.4 µs 2.3 µs +3.77%

@kdy1 kdy1 changed the title fix(es/typescript): Correct Type fix(es/typescript): Fix typings Jul 20, 2024
@kdy1 kdy1 merged commit 27ca712 into swc-project:main Jul 20, 2024
155 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.7.1 Jul 20, 2024
@magic-akari magic-akari deleted the wasm-typescript/type branch July 24, 2024 06:07
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants