Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Fix case matching #9208

Merged
merged 3 commits into from
Jul 11, 2024
Merged

fix(es/minifier): Fix case matching #9208

merged 3 commits into from
Jul 11, 2024
+18 −1

Conversation

CPunisher
Copy link
Contributor

@CPunisher CPunisher commented Jul 11, 2024 •
edited by kdy1
Loading

Description:

Caused by #7112
Since swc minifier evaluates expressions in a separate pass, I make a temporary patch here.

Related issue:

@CPunisher CPunisher requested a review from a team as a code owner July 11, 2024 12:08
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9208 will degrade performances by 31.99%

Comparing CPunisher:fix/invalid-case-matching (e315725) with CPunisher:fix/invalid-case-matching (cb203c9)

Summary

❌ 1 regressions
✅ 173 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark CPunisher:fix/invalid-case-matching CPunisher:fix/invalid-case-matching Change
❌ es/full/base/resolver_and_hygiene 328.9 µs 483.6 µs -31.99%

kdy1
kdy1 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_minifier
  • swc_core

@kdy1 kdy1 changed the title fix(es/minifier): invalid case matching fix(es/minifier): Fix case matching Jul 11, 2024
@kdy1 kdy1 enabled auto-merge (squash) July 11, 2024 14:01
swc-bot
swc-bot reviewed Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit f81fa6e into swc-project:main Jul 11, 2024
151 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.7.0 Jul 14, 2024
@Loonz806 Loonz806 mentioned this pull request Aug 8, 2024
Closed
@kdy1 kdy1 mentioned this pull request Aug 12, 2024
Merged
@Loonz806 Loonz806 mentioned this pull request Aug 15, 2024
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

minifier: invalid case matching in switch statement
3 participants
@CPunisher @kdy1 @swc-bot